gabriellefu commented on code in PR #22634:
URL: https://github.com/apache/kafka/pull/22634#discussion_r3454815454
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2119,6 +2124,13 @@ private CoordinatorResult<StreamsGroupHeartbeatResult,
CoordinatorRecord> stream
.maybeUpdateProcessId(Optional.ofNullable(processId))
.maybeUpdateClientTags(Optional.ofNullable(clientTags).map(x ->
x.stream().collect(Collectors.toMap(KeyValue::key, KeyValue::value))));
+ if (taskOffsets != null) {
Review Comment:
If there's nothing change, this field will be set as null, and if there's
any change, all the offset will be sent to the broker. So I think maybe
checking null is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
