kevin-wu24 commented on code in PR #22111:
URL: https://github.com/apache/kafka/pull/22111#discussion_r3437401024
##########
raft/src/testFixtures/java/org/apache/kafka/raft/RaftClientTestContext.java:
##########
@@ -998,8 +998,13 @@ void advanceTimeAndCompleteFetch(
int leaderId,
boolean expireUpdateVoterSetTimer
) throws Exception {
+ final var state = client.quorum().followerStateOrThrow();
Review Comment:
Hmmm, it looks like
https://github.com/apache/kafka/pull/22111#discussion_r3417002313 was because
some auto-join tests would fail without this change. It's been a while since I
changed this.
Subsequent invocations to this method can expire the fetch timeout. Prior to
this change, the local node did not change state, but now you go to
`Unattached`, so completing the fetch transitions the node back to `Follower`,
but with a new `updateVoterSetTimer` that is not expired. This causes the test
to fail on the second assertion of sending add/remove voter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
