lucasbru commented on code in PR #22595:
URL: https://github.com/apache/kafka/pull/22595#discussion_r3435944845
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -442,6 +448,36 @@ private void
addToExceptionsAndFailedTasksThenClearUpdatingAndPausedTasks(final
}
}
+ private void updateTaskOffsetSumSnapshot() {
+ final Map<StreamsRebalanceData.TaskId, Long> snapshot = new
HashMap<>(updatingTasks.size());
+ for (final Task task : updatingTasks.values()) {
Review Comment:
I wonder more generally, shouldn't we report the lag of _all_ tasks? There
can also be tasks on disk, which I vaguely remember we fetch the offset of as
well in the classic protocol. Or am I misremembering? It seems like we should
make this as complete as possible, so just including updating tasks may not be
sufficient?
Paused seems like a less important corner case, but it's still true - if we
we have a paused task here, why shouldn't we assign it here. Why overreport the
lag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
