Shekharrajak commented on code in PR #22357:
URL: https://github.com/apache/kafka/pull/22357#discussion_r3423526855
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTransactionTest.java:
##########
@@ -247,4 +313,49 @@ private ProducerRecord<byte[], byte[]> record(String
value) {
byte[] bytes = value.getBytes(StandardCharsets.UTF_8);
return new ProducerRecord<>(tp.topic(), tp.partition(), null, bytes,
bytes);
}
+
+ private ProducerRecord<byte[], byte[]> record(TopicPartition
topicPartition, String value) {
+ byte[] bytes = value.getBytes(StandardCharsets.UTF_8);
+ return new ProducerRecord<>(topicPartition.topic(),
topicPartition.partition(), null, bytes, bytes);
+ }
+
+ private TopicIdPartition createTopicIdPartitionWithRemoteShareCoordinator(
Review Comment:
Creates topics until it finds a source partition led by the requested broker
and whose mapped __share_group_state partition is led by a different broker.
This makes the remote tests
actually exercise the distributed path instead of accidentally passing
in a colocated single-broker layout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
