AndrewJSchofield commented on code in PR #22187:
URL: https://github.com/apache/kafka/pull/22187#discussion_r3381322389
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1529,10 +1529,22 @@ class KafkaApis(val requestChannel: RequestChannel,
apiVersionRequest.getErrorResponse(requestThrottleMs,
Errors.UNSUPPORTED_VERSION.exception)
} else if (!apiVersionRequest.isValid) {
apiVersionRequest.getErrorResponse(requestThrottleMs,
Errors.INVALID_REQUEST.exception)
+ } else if (clusterIdOrNodeIdIsInvalid(apiVersionRequest)) {
Review Comment:
I don't believe so. The cluster ID is passed as a constructor parameter into
KafkaApis. It appears to me that the broker initialisation has sufficiently
progressed by the time that requests are accepted that the cluster ID is known.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
