lianetm commented on code in PR #22138:
URL: https://github.com/apache/kafka/pull/22138#discussion_r3357571853
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##########
@@ -1642,7 +1638,7 @@ public void
testAsyncConsumerCloseLeavesGroupOnInterrupt() throws Exception {
));
}
- private void testCloseLeavesGroupOnInterrupt(Map<String, Object>
consumerConfig) throws Exception {
+ private void testCloseRunsRevocationCallbackOnInterrupt(Map<String,
Object> consumerConfig) throws Exception {
Review Comment:
given that we're not really testing any interaction with the broker anymore,
should this be now a unit test instead? (we could then ensure not only that the
callbacks run, but also that the event "LeaveGroupOnCloseEvent" is sent). Worth
double checking AsyncKafkaConsumerTEst in case we already have that coverage,
but I couldn't see it from a quick look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
