adikou commented on PR #22129: URL: https://github.com/apache/kafka/pull/22129#issuecomment-4564405783
> Do you have an example of how these log lines will be helpful? Also as I said earlier the change is very minimal so will merge but I ll still wait to hear how these logs are going to help. The main use case that drove me here was writing a custom metricsreporter. In addition to that, we leverage the metrics API to write custom metrics for our pollers/producer intereceptors. Sometimes I have a filter on the metricname and when I was debugging why a metric wasn't showing up I wanted to see was it even registered with the reporter and logs are my only way. I know you said logging the metric name would suffice here, but logging the simple class name of the metric value provider tells me I registered the right stat for said metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
