adikou commented on code in PR #22270:
URL: https://github.com/apache/kafka/pull/22270#discussion_r3313765248
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##########
@@ -154,18 +171,45 @@ public interface ConsumerRebalanceListener {
* necessary to catch these exceptions and re-attempt to wakeup or
interrupt the consumer thread.
*
* @param partitions The list of partitions that were assigned to the
consumer and now need to be revoked. This will
- * include the full assignment under the Classic/Eager
protocol, given that it revokes all partitions.
+ * include the full assignment under the Classic/Eager
protocol, given that it revokes all partitions.
* It will only include the subset to revoke under the
Classic/Cooperative and Consumer protocols.
* @throws org.apache.kafka.common.errors.WakeupException If raised from a
nested call to {@link KafkaConsumer}
* @throws org.apache.kafka.common.errors.InterruptException If raised
from a nested call to {@link KafkaConsumer}
*/
- void onPartitionsRevoked(Collection<TopicPartition> partitions);
+ default void onPartitionsRevoked(Collection<TopicPartition> partitions) {}
Review Comment:
I think I see what you mean when you said legacy.
~~We can provide two methods
`setConsumerRebalanceListener(ConsumerRebalanceListener)` and
`setRebalanceListener(RebalanceListener)`.
We can introduce `setConsumerRebalanceListener` as deprecated right out of
the gate and remove in AK5.0.~~
edit: We can support both listeners with just `setRebalanceListener` as
you've pointed out that we implement the super interface methods in the sub. We
can just invoke the new api and it will propagate down by default.
LMK if this aligns with your thinking.
edit: I think we followed this pattern for OffsetResetStrategy and
AutoOffsetResetStrategy iirc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
