lianetm commented on code in PR #21080:
URL: https://github.com/apache/kafka/pull/21080#discussion_r3311264270
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##########
@@ -135,10 +135,19 @@ public class RestoreIntegrationTest {
@BeforeAll
public static void startCluster() throws IOException {
CLUSTER.start();
-
+
final Properties adminConfig = new Properties();
adminConfig.put(CommonClientConfigs.BOOTSTRAP_SERVERS_CONFIG,
CLUSTER.bootstrapServers());
admin = Admin.create(adminConfig);
+
+ // Trigger initial bootstrap to ensure AdminClient thread doesn't exit
prematurely
+ // With KIP-909 deferred DNS resolution, AdminClient thread may exit
before first use
Review Comment:
uhm ok, but this is still a workaround that I don't get, why do we need it?
(just concerned we may have something broken/missing in the admin client?)
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
Review Comment:
don't we need here the same check we have in the NetworkClient to
rebootstrap only if we bootstrapped already?
https://github.com/frankvicky/kafka/blob/82752bb013060e3b96648b86fd5b5bacdd502f0e/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java#L1422
(relates to the workaround we're needing in the admin tests maybe?? I expect
this should be consistent for both clients, we don't allow it on the network
client but seems we allow it here?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
