ahuang98 commented on code in PR #22191:
URL: https://github.com/apache/kafka/pull/22191#discussion_r3306663297
##########
core/src/test/scala/unit/kafka/server/ControllerRegistrationManagerTest.scala:
##########
@@ -99,6 +99,9 @@ class ControllerRegistrationManagerTest {
failedAttempts.get(30, TimeUnit.SECONDS)
}
+ // This method simulates a metadata update by applying the given registration
+ // and unregistration modifiers to the previous image, and then calling
Review Comment:
hm, was hoping the comment would explain how the modifiers should be used in
more detail. but I can see how that might be difficult.
maybe an example might help? (e.g. `_ => None` means no
registration/unregistration record will be replayed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
