adikou commented on code in PR #22270:
URL: https://github.com/apache/kafka/pull/22270#discussion_r3306000405
##########
core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala:
##########
@@ -166,12 +166,12 @@ abstract class AbstractConsumerTest extends
BaseRequestTest {
var callsToAssigned = 0
var callsToRevoked = 0
- def onPartitionsAssigned(partitions:
java.util.Collection[TopicPartition]): Unit = {
+ override def onPartitionsAssigned(partitions:
java.util.Collection[TopicPartition]): Unit = {
Review Comment:
Same. Kind of reminds me of EJ Item 12, always use the Override anno. We do
miss it in a couple of places as well in the impl. I think [2/N] covers this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
