lianetm commented on code in PR #22296:
URL: https://github.com/apache/kafka/pull/22296#discussion_r3298772402
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##########
@@ -155,6 +155,8 @@ protected void handleFetchSuccess(final Node fetchTarget,
final FetchResponse response = (FetchResponse) resp.responseBody();
final FetchSessionHandler handler =
sessionHandler(fetchTarget.id());
+ metricsManager.recordLatency(resp.destination(),
resp.requestLatencyMs());
Review Comment:
this line should fix the gap for the Async and Classic consumer I expect.
We would just need to add tests to validate it (same as the one added here
for the share consumer, but using an error like FETCH_SESSION_TOPIC_ID_ERROR
maybe), added to FetcherTest for the classic, and in FetchRequestManagerTest
for the async.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
