majialoong commented on PR #22266:
URL: https://github.com/apache/kafka/pull/22266#issuecomment-4525623620
@chia7712 Thanks for the review, I've simplified the output.
Now it will directly show you how to proceed. There are two steps:
1. Add the missing NOTICE to NOTICE-binary (it will directly print the
NOTICE information that needs to be copied, thus avoiding manually unzipping
the JAR file).
3. Remove the outdated parts from NOTICE-binary (it will show the line
numbers that need to be deleted).
for example:
```
NOTICE-binary needs updates:
1. Copy 1 NOTICE text block(s) from `ADD TO NOTICE-binary` into
NOTICE-binary.
2. Delete 2 existing block(s) listed under `REMOVE FROM NOTICE-binary`.
==============================================================================
ADD TO NOTICE-binary (1 NOTICE text block(s))
==============================================================================
For each item, source jar(s) are reference only.
Copy only the text between COPY START and COPY END into NOTICE-binary.
--- ACTION: ADD NOTICE TEXT [01] ------------------------------------------
Source jar(s) (reference only):
- scala-library-2.13.18.jar (NOTICE)
- scala-reflect-2.13.18.jar (NOTICE)
>>> COPY START: NOTICE TEXT [01]
Scala
Copyright (c) 2002-2025 EPFL
Copyright (c) 2011-2025 Lightbend, Inc. dba Akka
Scala includes software developed at
LAMP/EPFL (https://lamp.epfl.ch/) and
Akka (https://akka.io/).
Licensed under the Apache License, Version 2.0 (the "License").
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
This software includes projects with other licenses -- see `doc/LICENSE.md`.
<<< COPY END: NOTICE TEXT [01]
==============================================================================
REMOVE FROM NOTICE-binary (2 existing block(s))
==============================================================================
Delete these line ranges from NOTICE-binary:
[01] NOTICE-binary:L820-L835
[02] NOTICE-binary:L843-L843
Re-run `python committer-tools/verify_notice.py --skip-build` after updating
NOTICE-binary.
```
Only steps requiring updates will be displayed; if no updates are needed,
the following will be output:
```
NOTICE-binary fully matches current third-party jar NOTICEs.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
