lucasbru commented on code in PR #21799:
URL: https://github.com/apache/kafka/pull/21799#discussion_r3288250551
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1972,7 +1973,8 @@ private CoordinatorResult<StreamsGroupHeartbeatResult,
CoordinatorRecord> stream
Endpoint userEndpoint,
List<KeyValue> clientTags,
boolean shutdownApplication,
- int memberEndpointEpoch
+ int memberEndpointEpoch,
+ short requestVersion
Review Comment:
This parameter is plumbed through but isn't read anywhere in the method
body. If we're not going to branch on it (e.g. to populate the legacy field for
v0), can we drop it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
