smjn commented on code in PR #22209: URL: https://github.com/apache/kafka/pull/22209#discussion_r3189406533
########## server-common/src/main/java/org/apache/kafka/server/share/dlq/DefaultShareGroupDLQManager.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.server.share.dlq; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.concurrent.CompletableFuture; + +/** + * The default share group DLQ manager responsible for processing + * incoming messages and writing them to the appropriate dlq topic. + */ +public class DefaultShareGroupDLQManager implements ShareGroupDLQ { + /** + * Reference to state manager responsible for actually sending + * the relevant RPCs and writing records. + */ + private final ShareGroupDLQStateManager stateManager; + + private static final Logger log = LoggerFactory.getLogger(DefaultShareGroupDLQManager.class); + + public DefaultShareGroupDLQManager(ShareGroupDLQStateManager stateManager) { + this.stateManager = stateManager; + this.stateManager.start(); Review Comment: Ok, will replace with factory. Public start method requires extra checking in call public methods. ########## server-common/src/main/java/org/apache/kafka/server/share/dlq/DefaultShareGroupDLQManager.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.server.share.dlq; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.concurrent.CompletableFuture; + +/** + * The default share group DLQ manager responsible for processing + * incoming messages and writing them to the appropriate dlq topic. + */ +public class DefaultShareGroupDLQManager implements ShareGroupDLQ { + /** + * Reference to state manager responsible for actually sending + * the relevant RPCs and writing records. + */ + private final ShareGroupDLQStateManager stateManager; + + private static final Logger log = LoggerFactory.getLogger(DefaultShareGroupDLQManager.class); + + public DefaultShareGroupDLQManager(ShareGroupDLQStateManager stateManager) { + this.stateManager = stateManager; + this.stateManager.start(); Review Comment: Ok, will replace with factory. Public start method requires extra checking in calls to public methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
