chickenchickenlove commented on code in PR #22204:
URL: https://github.com/apache/kafka/pull/22204#discussion_r3188386654
##########
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/RPCProducerIdManager.java:
##########
@@ -146,6 +156,9 @@ public void onTimeout() {
private void handleUnsuccessfulResponse() {
// There is no need to compare and set because only one thread
// handles the AllocateProducerIds response.
+
+ // KAFKA-20114 - Update the backoff before clearing requestInFlight.
maybeRequestNextBlock
+ // relies on this ordering when it acquires requestInFlight before
reading the deadline.
backoffDeadlineMs.set(time.milliseconds() + RETRY_BACKOFF_MS);
requestInFlight.set(false);
Review Comment:
This is very valid point, thanks a lot!
I've addressed it based on your comment!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
