mjsax commented on code in PR #21674:
URL: https://github.com/apache/kafka/pull/21674#discussion_r3186296371
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractSegments.java:
##########
@@ -59,7 +59,9 @@ abstract class AbstractSegments<S extends Segment> implements
Segments<S> {
protected abstract S createSegment(long segmentId, String segmentName);
- protected abstract void openSegmentDB(final S segment, final
StateStoreContext context);
+ protected void openSegment(final S segment, final StateStoreContext
context) {
+ segment.openDB(context.appConfigs(), context.stateDir());
+ }
Review Comment:
Yes, I am fine with not doing this refactoring and reverting it back -- it
was an idea, but I was also not fully convinced as you can see from my own
comments on the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
