chia7712 commented on code in PR #22201:
URL: https://github.com/apache/kafka/pull/22201#discussion_r3183789533
##########
build.gradle:
##########
@@ -1879,11 +1896,34 @@ project(':clients') {
archivesName = "kafka-clients"
}
+ apply plugin: 'java-test-fixtures'
+
configurations {
generator
shadowed
}
+ // java-test-fixtures creates dependencies testImplementation ->
testFixturesApi -> (main artifact)
Review Comment:
This is definitely a magic workaround... I noticed there are several issues
discussing this behavior
https://github.com/gradle/gradle/issues/19946
https://github.com/gradle/gradle/issues/11696
Anyway, good job finding this approach!
##########
build.gradle:
##########
@@ -313,6 +313,16 @@ subprojects {
task allDepInsight(type: DependencyInsightReportTask) {showingAllVariants =
false} doLast {}
apply plugin: 'java-library'
+
+ // Resolve conflict between testFixtures and shadow in :clients.
Review Comment:
Could you add a comment referencing the "magic workaround" in the clients
project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
