chia7712 commented on code in PR #22193:
URL: https://github.com/apache/kafka/pull/22193#discussion_r3178891141
##########
build.gradle:
##########
@@ -1574,6 +1578,32 @@ project(':group-coordinator') {
srcJar.dependsOn 'processMessages'
}
+project(':test-common:test-common-base') {
+ // Generic utilities for testing. Depends on `clients` only to minimize
classpath leakage.
+ // e.g. SSL utilities, wait functions, file-related operations
+ // Java 11 is the minimum Java version required.
+
+ base {
+ archivesName = "kafka-test-common-base"
+ }
+
+ dependencies {
+ implementation project(':clients')
Review Comment:
This reference causes AppInfoParserTest to fail, as it makes the test scope
depend on the JAR rather than class files. While not a serious issue, it does
prompt me to rethink the approach of this PR. Perhaps we should consider using
fixtures that allow us to keep the same package while maintaining isolation.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
