iit2009060 commented on PR #21535:
URL: https://github.com/apache/kafka/pull/21535#issuecomment-4012433576
@mjsax @lucasbru I found an existing bug where in the global processing
during deserialization failure we try to push record into DLQ, but that would
lead to class cast exception as GlobalProcessorContext would not be cast to
RecordCollector.supplier.
File Name: RecordDeserializer
` final List<ProducerRecord<byte[], byte[]>> deadLetterQueueRecords =
response.deadLetterQueueRecords();
if (!deadLetterQueueRecords.isEmpty()) {
final RecordCollector collector = ((RecordCollector.Supplier)
processorContext).recordCollector();
for (final ProducerRecord<byte[], byte[]> deadLetterQueueRecord
: deadLetterQueueRecords) {
collector.send(
deadLetterQueueRecord.key(),
deadLetterQueueRecord.value(),
sourceNodeName,
(InternalProcessorContext) processorContext,
deadLetterQueueRecord
);
}`
Should I create a bug ticket for this ?
FYI -I already started writing KIP for supporting DLQ. Should i handled this
while implementing it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
