josefk31 commented on code in PR #21028:
URL: https://github.com/apache/kafka/pull/21028#discussion_r2879477238


##########
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##########
@@ -108,6 +108,14 @@ public class QuorumConfig {
         "join the cluster metadata partition for its cluster id.";
     public static final boolean DEFAULT_QUORUM_AUTO_JOIN_ENABLE = false;
 
+    public static final String QUORUM_FETCH_SNAPSHOT_MAX_BYTES_CONFIG = 
QUORUM_PREFIX + "fetch.snapshot.max.bytes";
+    public static final String QUORUM_FETCH_SNAPSHOT_MAX_BYTES_DOC = "Maximum 
amount of data to retrieve for each FetchSnapshot request to the controller.";
+    public static final int DEFAULT_QUORUM_FETCH_SNAPSHOT_MAX_BYTES = 1048576;
+
+    public static final String QUORUM_FETCH_MAX_BYTES_CONFIG = QUORUM_PREFIX + 
"fetch.max.bytes";
+    public static final String QUORUM_FETCH_MAX_BYTES_DOC = "Maximum amount of 
data to retrieve for each Fetch request. Always returns at least one batch even 
if it is greater than QUORUM_FETCH_MAX_BYTES_CONFIG.";

Review Comment:
   I need to change this to `controller.quorum.fetch.max.bytes` or reword it to 
remove. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to