chickenchickenlove commented on code in PR #21565:
URL: https://github.com/apache/kafka/pull/21565#discussion_r2877906634
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8733,6 +8986,18 @@ private Map<String, String>
streamsGroupAssignmentConfigs(String groupId) {
return Map.of("num.standby.replicas", numStandbyReplicas.toString());
}
+ static boolean hasEpochRelevantMemberConfigChanged(
+ StreamsGroupMember oldMember,
+ StreamsGroupMember newMember
+ ) {
+ // The group epoch is bumped: (KIP-1071)
+ // - When a member updates its topology metadata, rack ID, client tags
or process ID.
+ return !Objects.equals(oldMember.topologyEpoch(),
newMember.topologyEpoch())
+ || !Objects.equals(oldMember.rackId(), newMember.rackId())
Review Comment:
Understood!
Would it make sense to split this into a separate PR so we can keep the
scope focused on static membership?
Which would you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
