brandboat commented on code in PR #21607:
URL: https://github.com/apache/kafka/pull/21607#discussion_r2871274453
##########
metadata/src/main/java/org/apache/kafka/metadata/ListenerInfo.java:
##########
@@ -134,7 +134,7 @@ public static ListenerInfo fromControllerRegistrationRecord(
* @return The ListenerInfo object.
*/
public static ListenerInfo fromBrokerRegistrationRequest(
- BrokerRegistrationRequestData.ListenerCollection collection
+ List<BrokerRegistrationRequestData.Listener> collection
) {
LinkedHashMap<String, Endpoint> listeners = new LinkedHashMap<>();
Review Comment:
Pardon me, could you please explain a bit more on this?
ImplicitLinkedHashMultiCollection#addInternal itself doesn't invoke
`elementKeysAreEqual`
https://github.com/apache/kafka/blob/11ad60b452edf527723b5d46c63bed76db153ac2/clients/src/main/java/org/apache/kafka/common/utils/ImplicitLinkedHashMultiCollection.java#L68-L83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
