chia7712 commented on code in PR #21555:
URL: https://github.com/apache/kafka/pull/21555#discussion_r2871117255
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -276,7 +280,14 @@ public GroupCoordinatorService build() {
.withSerializer(new GroupCoordinatorRecordSerde())
.withCompression(Compression.of(config.offsetTopicCompressionType()).build())
.withAppendLingerMs(config.appendLingerMs())
- .withExecutorService(Executors.newSingleThreadExecutor())
+ .withExecutorService(Executors.newFixedThreadPool(
+ config.numBackgroundThreads(),
+ runnable -> new KafkaThread(
Review Comment:
We can't use `Thread.ofPlatform()` because the server-side code targets JDK
17, and the client-side code is still on JDK 11.
maybe we could use
`ThreadUtils.createThreadFactory("group-coordinator-background-%d", false)`
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
