DL1231 commented on code in PR #21573:
URL: https://github.com/apache/kafka/pull/21573#discussion_r2870262627
##########
storage/src/test/java/org/apache/kafka/server/purgatory/DelayedRemoteListOffsetsTest.java:
##########
@@ -56,6 +65,7 @@ public class DelayedRemoteListOffsetsTest {
@AfterEach
public void afterEach() throws Exception {
purgatory.shutdown();
+ TestUtils.clearYammerMetrics();
Review Comment:
Thanks for the suggestion. The Java `TestUtils` lives in the clients module,
which does not have a dependency on server-common where `KafkaYammerMetrics`
resides. So we can't simply move `clearYammerMetrics()` there.
A few alternatives I can think of:
1. Inline the logic directly in this test class, since it's just two lines;
2. Keep the current Scala TestUtils call since storage already depends on
core test output, and there are other callers of this same method in storage
tests (e.g., `RemoteLogManagerTest`, `RemoteLogReaderTest`).
Which approach do you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
