showuon commented on PR #21609: URL: https://github.com/apache/kafka/pull/21609#issuecomment-3981672417
Note: Although the producer side already has validated the partition size is > 0, the stream side (like [here](https://github.com/apache/kafka/blob/c77a96d13238c3127dc8cf016d437efb5e64bfa9/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java#L480)) I cannot see all places have the partition size validation. Adding a validation in the partitionFor makes sense to me to avoid missing validation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
