chickenchickenlove commented on code in PR #20968:
URL: https://github.com/apache/kafka/pull/20968#discussion_r2868231106
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java:
##########
@@ -58,6 +58,11 @@ public ProcessorParameters(final
FixedKeyProcessorSupplier<KIn, VIn, VOut> proce
public ProcessorSupplier<KIn, VIn, KOut, VOut> processorSupplier() {
return processorSupplier;
}
+
+ public ProcessorSupplier<KIn, VIn, KOut, VOut>
wrappedProcessSupplier(final InternalTopologyBuilder topologyBuilder) {
+ ApiUtils.checkSupplier(processorSupplier);
+ return topologyBuilder.wrapProcessorSupplier(processorName,
processorSupplier);
+ }
Review Comment:
_so might be good to add a parallel wrappedFixedKeyProcessSupplier method_
It makes sense to me!
By the way, since `wrappedFixedKeyProcessSupplier` doesn’t seem to be
related to the `TableSource` optimization, how about handling it in a separate
issue and PR to minimize the review scope?
Let me know your opinion!
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/ProcessorParameters.java:
##########
@@ -58,6 +58,11 @@ public ProcessorParameters(final
FixedKeyProcessorSupplier<KIn, VIn, VOut> proce
public ProcessorSupplier<KIn, VIn, KOut, VOut> processorSupplier() {
return processorSupplier;
}
+
+ public ProcessorSupplier<KIn, VIn, KOut, VOut>
wrappedProcessSupplier(final InternalTopologyBuilder topologyBuilder) {
+ ApiUtils.checkSupplier(processorSupplier);
+ return topologyBuilder.wrapProcessorSupplier(processorName,
processorSupplier);
+ }
Review Comment:
_so might be good to add a parallel wrappedFixedKeyProcessSupplier method_
It makes sense to me!
By the way, since `wrappedFixedKeyProcessSupplier` doesn’t seem to be
related to the `TableSource` optimization, how about handling it in a separate
issue and PR to minimize the review scope?
Let me know your thoughts!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
