kirktrue commented on code in PR #21586:
URL: https://github.com/apache/kafka/pull/21586#discussion_r2862122797
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java:
##########
@@ -102,6 +102,7 @@ public class VerifiableConsumer implements Closeable,
OffsetCommitCallback, Cons
private final int maxMessages;
private final CountDownLatch shutdownLatch = new CountDownLatch(1);
private int consumedMessages = 0;
+ private boolean shutdownRequested = false;
Review Comment:
Either `volatile` or `AtomicBoolean` should work fine.
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java:
##########
@@ -295,6 +298,14 @@ public String name() {
}
}
+ private static class ShutdownRequested extends ConsumerEvent {
+
+ @Override
+ public String name() {
+ return "shutdown_requested";
Review Comment:
I'm not seeing anything in the `verifiable_consumer.py` (or elsewhere)
that's looking for this event. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
