wernerdv commented on code in PR #21519:
URL: https://github.com/apache/kafka/pull/21519#discussion_r2855120288
##########
server/src/test/java/org/apache/kafka/server/ReconfigurableQuorumIntegrationTest.java:
##########
@@ -168,27 +165,26 @@ public void testRemoveAndAddSameController() throws
Exception {
cluster.format();
cluster.startup();
try (var admin = cluster.admin()) {
- TestUtils.retryOnExceptionWithTimeout(30_000, 10, () -> {
+ retryOnExceptionWithTimeout(30_000, 10, () -> {
Map<Integer, Uuid> voters = findVoterDirs(admin);
assertEquals(Set.of(3000, 3001, 3002, 3003),
voters.keySet());
for (int replicaId : new int[] {3000, 3001, 3002, 3003}) {
assertNotEquals(Uuid.ZERO_UUID, voters.get(replicaId));
}
});
Uuid dirId =
cluster.nodes().controllerNodes().get(3000).metadataDirectoryId();
+ int port = port(admin, 3000);
admin.removeRaftVoter(3000, dirId).all().get();
- TestUtils.retryOnExceptionWithTimeout(30_000, 10, () -> {
+ retryOnExceptionWithTimeout(30_000, 10, () -> {
Map<Integer, Uuid> voters = findVoterDirs(admin);
assertEquals(Set.of(3001, 3002, 3003), voters.keySet());
for (int replicaId : new int[] {3001, 3002, 3003}) {
assertNotEquals(Uuid.ZERO_UUID, voters.get(replicaId));
}
});
- admin.addRaftVoter(
- 3000,
- dirId,
- Set.of(new RaftVoterEndpoint("CONTROLLER", "example.com",
8080))
- ).all().get();
+
+ retryOnExceptionWithTimeout(30_000, 1_000, () ->
Review Comment:
Yes, retrying these calls will make the tests more stable.
I've reverted the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
