mimaison commented on code in PR #21273:
URL: https://github.com/apache/kafka/pull/21273#discussion_r2846218654
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -577,8 +577,20 @@ class DynamicLogConfig(logManager: LogManager) extends
BrokerReconfigurable with
}
}
+ def validateCordonedLogDirs(): Unit = {
Review Comment:
Yes you need to uncordon the log directory with the Admin API by connecting
to the controller before restarting the broker. I think that process is fine.
The KIP promises to update the [Decommissioning
brokers](https://kafka.apache.org/42/operations/basic-kafka-operations/#decommissioning-brokers)
section in the docs. That will also include the steps to decommission a log
directory.
I wanted to have tests to exercise these decommissioning scenarios before
updating the docs. I've written a test to decommission a broker. To
decommission a log directory you need to update the broker config and
`ClusterTest` is not really designed handle this. I'll either add these to
https://github.com/apache/kafka/pull/21523 or in a follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
