squah-confluent commented on code in PR #21522:
URL: https://github.com/apache/kafka/pull/21522#discussion_r2838295476
##########
tools/src/test/java/org/apache/kafka/tools/streams/DescribeStreamsGroupTest.java:
##########
@@ -73,6 +73,7 @@ public class DescribeStreamsGroupTest {
private static final String INPUT_TOPIC_2 = "customInputTopic2";
private static final String OUTPUT_TOPIC_2 = "customOutputTopic2";
private static String bootstrapServers;
+ @SuppressWarnings("removal")
Review Comment:
nit: missing newline before
```suggestion
@SuppressWarnings("removal")
```
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -65,8 +65,13 @@ public class GroupCoordinatorConfig {
///
/// Group coordinator configs
///
+ @Deprecated(since = "4.3", forRemoval = true)
public static final String GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG =
"group.coordinator.rebalance.protocols";
- public static final String GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC =
"The list of enabled rebalance protocols.";
+ @Deprecated(since = "4.3", forRemoval = true)
+ public static final String GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC =
"This configuration is deprecated and will be removed in Kafka 5.0. " +
+ "The list of enabled rebalance protocols. " +
+ "In Kafka 5.0, all protocols will always be enabled and cannot be
disabled via this configuration. " +
+ "Use feature versions (group.version, streams.version, share.version)
managed by kafka-features.sh instead.";
public static final List<String>
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT = List.of(
Review Comment:
I'm curious about why we didn't also mark
`GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DEFAULT` as `@Deprecated`.
##########
docs/getting-started/upgrade.md:
##########
@@ -36,6 +36,7 @@ type: docs
* Two new configs have been introduced:
`group.coordinator.cached.buffer.max.bytes` and
`share.coordinator.cached.buffer.max.bytes`. They allow the respective
coordinators to set the maximum buffer size retained for reuse. For further
details, please refer to
[KIP-1196](https://cwiki.apache.org/confluence/x/hA5JFg).
* The new config have been introduced: `remote.log.metadata.topic.min.isr`
with 2 as default value. You can correct the min.insync.replicas for the
existed __remote_log_metadata topic via kafka-configs.sh if needed. For further
details, please refer to
[KIP-1235](https://cwiki.apache.org/confluence/x/yommFw).
* The new config prefix `remote.log.metadata.admin.` has been introduced. It
allows independent configuration of the admin client used by
`TopicBasedRemoteLogMetadataManager`. For further details, please refer to
[KIP-1208](https://cwiki.apache.org/confluence/x/vYqhFg).
+ * The `group.coordinator.rebalance.protocols` configuration is deprecated
and will be removed in Kafka 5.0. In Kafka 5.0, all protocols will always be
enabled and controlled solely by feature versions (group.version,
streams.version, share.version) via kafka-features.sh. For further details,
please refer to [KIP-1237](https://cwiki.apache.org/confluence/x/jIqmFw).
Review Comment:
```suggestion
* The `group.coordinator.rebalance.protocols` configuration is deprecated
and will be removed in Kafka 5.0. In Kafka 5.0, all protocols will always be
enabled and controlled solely by feature versions (`group.version`,
`streams.version`, `share.version`) via `kafka-features.sh`. For further
details, please refer to
[KIP-1237](https://cwiki.apache.org/confluence/x/jIqmFw).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
