see-quick commented on PR #21406: URL: https://github.com/apache/kafka/pull/21406#issuecomment-3895626670
> I understand the goal is a 1:1 migration. However, since we'd touching these legacy styles, would you be open to some refactoring as part of this PR? I was wondering about it at first glance ... but wouldn't be better to make just follow-up PRs purely on refactor those legacy styles? I mean that way at least we can review behavioral changes and structural improvements independently? If you think we should do it in this PR I can do it for sure but I think for keeping migration easy I would stick with 1:1 migration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
