mjsax commented on code in PR #20955:
URL: https://github.com/apache/kafka/pull/20955#discussion_r2801776653
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/MeteredVersionedKeyValueStoreTest.java:
##########
@@ -224,10 +224,10 @@ public void
shouldDelegateAndRecordMetricsOnGetWithTimestamp() {
}
@Test
- public void shouldDelegateAndRecordMetricsOnFlush() {
- store.flush();
+ public void shouldDelegateAndRecordMetricsOnCommit() {
+ store.commit(Map.of());
- verify(inner).flush();
+ verify(inner).commit(Map.of());
assertThat((Double) getMetric("flush-rate").metricValue(),
greaterThan(0.0));
Review Comment:
@nicktelford @bbejeck -- just came across this code on some other PR review,
and wondering if we need to update this, and also check if the new
`commit-rate` metric was bumped?
Same question for other store types?
We are just adding a new metered store and corresponding test -- if this
will be changed in a follow up PR, please make sure to also cover the newly
added `MeteredTimestampedKeyValueStoreWithHeadersTest`
Cf https://github.com/apache/kafka/pull/21451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
