[
https://issues.apache.org/jira/browse/KAFKA-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794967#comment-16794967
]
ASF GitHub Bot commented on KAFKA-8121:
---------------------------------------
rajinisivaram commented on pull request #6462: KAFKA-8121; Shutdown ZK client
expiry handler earlier during close
URL: https://github.com/apache/kafka/pull/6462
Shutdown session expiry thread prior to closing ZooKeeper client to ensure
that new clients are not created by the expiry thread and left active when
returning from `ZooKeeperClient.close()`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ZooKeeperClient session expiry thread may leave clients behind after close
> --------------------------------------------------------------------------
>
> Key: KAFKA-8121
> URL: https://issues.apache.org/jira/browse/KAFKA-8121
> Project: Kafka
> Issue Type: Bug
> Reporter: Rajini Sivaram
> Assignee: Rajini Sivaram
> Priority: Major
>
> Test failure after merging KAFKA-8118:
> {code:java}
> java.lang.AssertionError: Found unexpected threads during @AfterClass,
> allThreads=Set(/127.0.0.1:51186 to /127.0.0.1:40791 workers Thread 3,
> metrics-meter-tick-thread-2, main, Signal Dispatcher, Reference Handler,
> zk-session-expiry-handler0-SendThread(localhost:35825),
> zk-session-expiry-handler0-EventThread, scala-execution-context-global-1903,
> Test worker, scala-execution-context-global-34,
> scala-execution-context-global-5352, scala-execution-context-global-234,
> Finalizer, scala-execution-context-global-235, /127.0.0.1:51186 to
> /127.0.0.1:40791 workers Thread 2, metrics-meter-tick-thread-1),
> unexpected=Set(zk-session-expiry-handler0-EventThread)
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at
> kafka.zk.ZooKeeperTestHarness$.verifyNoUnexpectedThreads(ZooKeeperTestHarness.scala:129)
> at
> kafka.zk.ZooKeeperTestHarness$.tearDownClass(ZooKeeperTestHarness.scala:114)
> at
> kafka.zk.ZooKeeperTestHarness.tearDownClass(ZooKeeperTestHarness.scala){code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
