jsancio commented on code in PR #21221:
URL: https://github.com/apache/kafka/pull/21221#discussion_r2683991278
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1247,40 +1260,48 @@ private Errors validateAlterPartitionData(
return UNKNOWN_TOPIC_OR_PARTITION;
}
+ String partitionChangeInfo = String.format("Proposed ISR was %s and
current ISR is %s. " +
+ "Current replica set is %s. Proposed partitionEpoch was %d and
current partitionEpoch is %d. " +
+ "Proposed leaderEpoch was %d and current leaderEpoch is %d.",
Review Comment:
> I can also just log the current partitionEpoch and leaderEpoch information
given that any error with those fields will already log the epoch that was
contained in the request
Yeah. It is probably good to not duplicate information if we don't have to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
