ahuang98 commented on code in PR #21053:
URL: https://github.com/apache/kafka/pull/21053#discussion_r2677245775
##########
metadata/src/main/java/org/apache/kafka/image/ConfigurationDelta.java:
##########
@@ -31,6 +34,17 @@
public final class ConfigurationDelta {
private final ConfigurationImage image;
private final Map<String, Optional<String>> changes = new HashMap<>();
+ private static final AtomicReference<Set<String>> VALID_CONFIGS_REF = new
AtomicReference<>(null);
Review Comment:
guessing this is an atomicReference because we're worried about calling
initializeValidConfigs more than once (presumably on accident). this could be
avoided if we instantiate this value as part of the ConfigurationDelta
constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
