kirktrue commented on code in PR #21198:
URL: https://github.com/apache/kafka/pull/21198#discussion_r2670522553
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -221,13 +238,24 @@ boolean doSend(final UnsentRequest r, final long
currentTimeMs) {
log.debug("No broker available to send the request: {}.
Retrying.", r);
return false;
}
+
+ // Check if we're still in backoff period for this node
+ long backoffDelay = getBackoffDelay(node, currentTimeMs);
+ if (backoffDelay > 0) {
+ // Still in backoff period, skip retry
+ return false;
Review Comment:
`ready()` has several conditions in which it could return `false`. For some
of them (e.g. connecting state), it may make sense to back off, but for others
(e.g. busy sending a metadata request), not so much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
