showuon commented on PR #21211:
URL: https://github.com/apache/kafka/pull/21211#issuecomment-3713024957
Yes, I don't understand the issue, either. We should already set the
adjustMaxBytes into fetchInfo and then the asyncRead for tiered storage should
honor it. So in your example:
```
For example, with fetch.max.bytes=1MB:
If partition 1 returns 1 MB from local storage
And partition 2 returns 1 MB from tiered storage
The total response can be 2 MB, exceeding the configured limit
```
When readFromLog for the tiered storage partition, it should return an empty
`remoteStorageFetchInfo` due to 0 `adjustedMaxBytes`
[here](https://github.com/apache/kafka/blob/bb300ef757d8501b58f6923759a48f15753ff69b/core/src/main/scala/kafka/server/ReplicaManager.scala#L1945-L1951).
That is, we won't do any remote read in this case and only return 1MB of data
from local storage. Did I miss anything?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
