dnadolny commented on code in PR #21065:
URL: https://github.com/apache/kafka/pull/21065#discussion_r2662671007
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##########
@@ -354,6 +359,24 @@ private boolean
shouldHandleAuthorizationError(RuntimeException exception) {
return false;
}
+ private void failExpiredBatches(List<ProducerBatch> expiredBatches, long
now, boolean deallocateBuffer) {
+ // Reset the producer id if an expired batch has previously been sent
to the broker. Also update the metrics
Review Comment:
This is the code from `sendProducerData` with only one modification: on line
372 we pass in the `deallocateBuffer` arg to `failBatch`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]