[
https://issues.apache.org/jira/browse/KAFKA-8091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789444#comment-16789444
]
ASF GitHub Bot commented on KAFKA-8091:
---------------------------------------
rajinisivaram commented on pull request #6425: KAFKA-8091; Wait for processor
shutdown before testing removed listeners
URL: https://github.com/apache/kafka/pull/6425
`DynamicBrokerReconfigurationTest.testAddRemoveSaslListeners` removes a
listener, waits for the config to be propagated to all brokers and then
validates that connections to the removed listener fail. But there is a small
timing window between config update and Processor shutdown. Before validating
that connections to a removed listener fail, this PR waits for all metrics of
the removed listener to be deleted, ensuring that the Processors of the
listener have been shutdown.
Ran the test with the fix 1000 times over the weekend without any failures.
It failed after ~200 runs without the fix.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Flaky test DynamicBrokerReconfigurationTest#testAddRemoveSaslListener
> -----------------------------------------------------------------------
>
> Key: KAFKA-8091
> URL: https://issues.apache.org/jira/browse/KAFKA-8091
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 2.2.0
> Reporter: Rajini Sivaram
> Assignee: Rajini Sivaram
> Priority: Critical
> Fix For: 2.3.0, 2.2.1
>
>
> See KAFKA-6824 for details. Since the SSL version of the test is currently
> skipped using @Ignore, fixing this for SASL first and wait for that to be
> stable before re-enabling SSL tests under KAFKA-6824.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
