mjsax commented on code in PR #20320:
URL: https://github.com/apache/kafka/pull/20320#discussion_r2628810924
##########
tools/src/test/java/org/apache/kafka/tools/streams/DescribeStreamsGroupTest.java:
##########
@@ -233,18 +231,19 @@ public void
testDescribeMultipleStreamsGroupWithMembersAndVerboseOptions() throw
// The TARGET-ASSIGNMENT-EPOCH and MEMBER-EPOCH can vary due to
rebalance timing, so we don't care about them either.
final List<Integer> dontCares = List.of(1, 3, 5, 6, 7);
- validateDescribeOutput(
- List.of("--bootstrap-server", bootstrapServers, "--describe",
"--members", "--verbose", "--group", APP_ID, "--group", APP_ID_2),
- expectedHeader, expectedRowsMap, dontCares);
- validateDescribeOutput(
- List.of("--bootstrap-server", bootstrapServers, "--describe",
"--verbose", "--members", "--group", APP_ID, "--group", APP_ID_2),
- expectedHeader, expectedRowsMap, dontCares);
- validateDescribeOutput(
- List.of("--bootstrap-server", bootstrapServers, "--describe",
"--verbose", "--members", "--all-groups"),
- expectedHeader, expectedRowsMap, dontCares);
-
- streams2.close();
- streams2.cleanUp();
Review Comment:
Seems we are loosing this `cleanUp()` call with the current rewrite. Maybe
we cannot use `try-with-resource` for this case, but would to add regular
try-catch and put both `close()` and `cleanUp` into the finally block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
