kamalcph commented on code in PR #21150:
URL: https://github.com/apache/kafka/pull/21150#discussion_r2625526156
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -143,6 +143,11 @@
* - also provides APIs to fetch indexes, metadata about remote log segments
* - copying log segments to the remote storage
* - cleaning up segments that are expired based on retention size or
retention time
+ * <p>
Review Comment:
This Javadoc should be moved to RemoteStorageManager instead.
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -1044,6 +1049,9 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, RemoteLogSegment
try {
customMetadata =
remoteStorageManagerPlugin.get().copyLogSegmentData(copySegmentStartedRlsm,
segmentData);
+ } catch (RetriableRemoteStorageException e) {
+ logger.info("Copy failed with retriable error for segment {}",
copySegmentStartedRlsm.remoteLogSegmentId());
+ throw e;
} catch (RemoteStorageException e) {
logger.info("Copy failed, cleaning segment {}",
copySegmentStartedRlsm.remoteLogSegmentId());
try {
Review Comment:
We also have to handle the RetriableRemoteStorageException in RLMTask L844,
so that it won't be logged as WARN log.
```
} catch (RetriableException | RetriableRemoteStorageException ex) {
logger.debug("Encountered a retryable error while executing
current task for partition {}", topicIdPartition, ex);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
