kevin-wu24 commented on code in PR #21122:
URL: https://github.com/apache/kafka/pull/21122#discussion_r2608419593
##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
@@ -158,9 +158,10 @@ class ControllerServer(
val apiVersionManager = new SimpleApiVersionManager(
ListenerType.CONTROLLER,
config.unstableApiVersionsEnabled,
- () => featuresPublisher.features().setFinalizedLevel(
- KRaftVersion.FEATURE_NAME,
- raftManager.client.kraftVersion().featureLevel())
+ () => featuresPublisher.features().map(f =>
Review Comment:
If so, one way to fix this is to add a `NOT_FINALIZED` enum value to
`MetadataVersion`. This option makes the most sense to me.
Or we can make `FinalizedFeatures#metadataVersion` field an optional, and
keep it so that `FinalizedFeatures` does not have to be an optional (although
this seems confusing when the object is called "FinalizedFeatures").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
