ahuang98 commented on PR #20938: URL: https://github.com/apache/kafka/pull/20938#issuecomment-3634844227
@jiafu1115 thanks for the response and for testing it out manually! Good to see that the config isn't picked up by the other controllers. I wanted to clarify that my bigger concern (maybe uninformed concern since I'm not very familiar with config code) is that we are able to set the config for individual controllers, but they might not actually take effect. For instance, maybe kafka correctly creates a config record in the metadata log that broker id 1001 has this new config, but is controller 1001 actually able to apply this config (would it actually limit max connections at the new value). And, we probably need additional tests in the code for the dynamic config update (for instance, check out DynamicConfigChangeTest) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
