chia7712 commented on code in PR #21046:
URL: https://github.com/apache/kafka/pull/21046#discussion_r2600554436
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareFetchMetricsRegistry.java:
##########
@@ -60,18 +60,18 @@ public ShareFetchMetricsRegistry(Set<String> tags, String
metricGrpPrefix) {
this.fetchSizeMax = new MetricNameTemplate("fetch-size-max", groupName,
"The maximum number of bytes fetched per request", tags);
- this.bytesFetchedRate = new MetricNameTemplate("bytes-consumed-rate",
groupName,
+ this.bytesFetchedRate = new MetricNameTemplate("bytes-fetched-rate",
groupName,
"The average number of bytes consumed per second", tags);
- this.bytesFetchedTotal = new
MetricNameTemplate("bytes-consumed-total", groupName,
+ this.bytesFetchedTotal = new MetricNameTemplate("bytes-fetched-total",
groupName,
"The total number of bytes consumed", tags);
this.recordsPerRequestAvg = new
MetricNameTemplate("records-per-request-avg", groupName,
"The average number of records in each request", tags);
this.recordsPerRequestMax = new
MetricNameTemplate("records-per-request-max", groupName,
"The maximum number of records in a request.", tags);
- this.recordsFetchedRate = new
MetricNameTemplate("records-consumed-rate", groupName,
+ this.recordsFetchedRate = new
MetricNameTemplate("records-fetched-rate", groupName,
"The average number of records consumed per second", tags);
- this.recordsFetchedTotal = new
MetricNameTemplate("records-consumed-total", groupName,
+ this.recordsFetchedTotal = new
MetricNameTemplate("records-fetched-total", groupName,
Review Comment:
@JimmyWang6 would you mind removing those changes to keep the consistent
metrics between consumer and share consumer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
