dejan2609 commented on code in PR #21086: URL: https://github.com/apache/kafka/pull/21086#discussion_r2599252893
########## gradle/dependencies.gradle: ########## @@ -120,8 +120,8 @@ versions += [ // When updating the scalafmt version please also update the version field in checkstyle/.scalafmt.conf. scalafmt now // has the version field as mandatory in its configuration, see // https://github.com/scalameta/scalafmt/releases/tag/v3.1.0. Review Comment: Thanx for a sugestion @mingyen066 and lets try to decipher this together. It seems that link for a ScalaFmt version 3.1.0 release notes was introduced as a comment at some point in order to explain why ScalaFmt requires two references for a same version in these two files: 1. `gradle/dependencies.gradle` 2. `checkstyle/.scalafmt.conf` Thing is that this specific version (https://github.com/scalameta/scalafmt/releases/tag/v3.1.0) contains few changes related to version handling (and this is a directly related PR: `https://github.com/scalameta/scalafmt/pull/2843` **ScalafmtConfig: require `version` in a config file**) :bulb: Another option :arrow_right: directly related documentation link: https://scalameta.org/scalafmt/docs/configuration.html#version LMK which option sounds better for you: 1. replace ScalaFmt release notes version 3.1.0 link with docs link (mentioned above) OR 2. add docs link (in addition to ScalaFmt 3.1.0 link) OR 3. leave as-is <img width="729" height="604" alt="image" src="https://github.com/user-attachments/assets/99f91710-6937-45ee-ba1c-4689299b3f90"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
