apoorvmittal10 opened a new pull request, #21092:
URL: https://github.com/apache/kafka/pull/21092

   If a client application crashes then it can go in infinte loop where same 
records will be delivered. Though previously we chose to decrease the delivery 
count on session release as we didn't have throttling support. Now when we do 
then it makes sense to bump the delivery count on session close. Also as 
share-groups clients should ideally not have pre-fetched data hence it's safe 
to bump the delivery count on session release.
   
   I have not removed the code to decrease the delivery count as that 
functionality is well tested and we might need at the time of pre-fetching 
support or in cases where we do need not to bump the delivery count, in future.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to