smjn commented on PR #21027: URL: https://github.com/apache/kafka/pull/21027#issuecomment-3617250145
Hi @m1a2st , Thanks for the PR. While the code is valid, it would mutate the logger key for the internal handlers to ``` org.apache.kafka.server.share.persister.PersisterStateManager$WriteStateHandler ``` This would make it infeasible to turn on DEBUG, TRACE logging for these classes. For example on a local kafka cluster, these fail: 1. ``` bin/kafka-configs.sh --bootstrap-server localhost:9092 --alter --add-config "org.apache.kafka.server.share.persister.PersisterStateManager$WriteStateHandler=DEBUG" --entity-type broker-loggers --entity-name 1 Invalid broker logger(s): org.apache.kafka.server.share.persister.PersisterStateManager ``` 2. ``` bin/kafka-configs.sh --bootstrap-server localhost:9092 --alter --add-config "org.apache.kafka.server.share.persister.PersisterStateManager\$WriteStateHandler=DEBUG" --entity-type broker-loggers --entity-name 1 Invalid character found for config key: org.apache.kafka.server.share.persister.PersisterStateManager$WriteStateHandler ``` This was the reason why original code used `canonical` name, where possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
