chia7712 commented on code in PR #21026:
URL: https://github.com/apache/kafka/pull/21026#discussion_r2587649788
##########
Jenkinsfile:
##########
@@ -199,6 +199,25 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 23'
}
}
+ stage('JDK 25 and Scala 2.13') {
+ agent { label 'ubuntu' }
+ tools {
+ // Use JDK 21 instead of JDK 25 because Gradle 8 cannot run on JDK
25.
+ // While running Gradle with JDK 21, we use Gradle's Java
toolchain feature to build and test with JDK 25.
Review Comment:
JDK 25 is used solely for testing. The toolchain defined by `testWithJava25`
does not impact the build prorcess
##########
Jenkinsfile:
##########
@@ -199,6 +199,25 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 23'
}
}
+ stage('JDK 25 and Scala 2.13') {
+ agent { label 'ubuntu' }
+ tools {
+ // Use JDK 21 instead of JDK 25 because Gradle 8 cannot run on JDK
25.
+ // While running Gradle with JDK 21, we use Gradle's Java
toolchain feature to build and test with JDK 25.
+ jdk 'jdk_21_latest'
+ }
+ options {
+ timeout(time: 8, unit: 'HOURS')
+ timestamps()
+ }
+ environment {
+ SCALA_VERSION=2.13
+ }
+ steps {
+ doTest(env, 'testWithJava25')
Review Comment:
if we don't call `doValidation`, the test may be incorrectly skipped if
previous test results exist
##########
settings.gradle:
##########
@@ -16,6 +16,7 @@
plugins {
id 'com.gradle.enterprise' version '3.14.1'
id 'com.gradle.common-custom-user-data-gradle-plugin' version '1.11.1'
+ id 'org.gradle.toolchains.foojay-resolver-convention' version '0.8.0'
Review Comment:
Please add comment explaining why we can't use the latest version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
