mjsax commented on code in PR #20958:
URL: https://github.com/apache/kafka/pull/20958#discussion_r2566678962


##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StateUpdaterFailureIntegrationTest.java:
##########
@@ -146,6 +148,8 @@ public void flush() {
 
         streams.removeStreamThread();
 
+        TestUtils.waitForCondition(() -> streams.state() == 
KafkaStreams.State.REBALANCING, TimeUnit.MINUTES.toMillis(2), "Streams never 
reached REBALANCING state");

Review Comment:
   Ah. Interesting. Did dig into this and found the root cause: 
https://github.com/apache/kafka/commit/ebae768bd89f8ee4f34a8c5fb05229e488fbdc82#diff-ab27af136b0c45ed402ec44368a91380b018bf06f1a9722324fe6be8d5220f7dR1204
   
   We can keep this condition (maybe reduce to 1 minute waiting time?), and 
additionally reduce session timeout to 10 sec to speed up the test?
   
   W/o sending a leave group request, the test hangs waiting for session 
timeout to expire on missing heartbeats from the removed thread.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to